fix(misunderstood): strip slots for amend screen #11214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUS-106 [BUG] Misunderstood | Utterance Slots polluting the view (botpress/studio #196)
In the Misunderstood module, only the utterance should show in the pop-up without the slot markup when amending to an intent. |
Merged
samuelmasse
added a commit
that referenced
this pull request
Jan 20, 2022
* chore(ci_cd): use gh-actions v1 (#11211) * chore(messaging): add a migration in the core to migrate messaging database (#5723) * create migration * runMessagingMigration * update version * bump messaging * bump versions * 0.0.1 migration * bot token migration * fix * fix * fix(misunderstood): strip slots for amend screen (#11214) * chore(deps): bump follow-redirects in /modules/.nlu-testing (#11212) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump follow-redirects from 1.13.1 to 1.14.7 in /modules/nlu (#11209) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump follow-redirects in /modules/channel-web (#11208) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update README.md (#5746) The links in the chat 3rd party Oauth and inter-bot communication weren't updated. So I updated them. * chore: update some libs to cover some vulns (#11215) * fix(misunderstood): strip slots for amend screen * chore: update multiple dependencies * updated translation checker script * updated translation checker script * fix(admin): create bot from template is fast again (#11218) * chore(ci_cd): added action to create release pull request (#11210) * chore(ci_cd): added action to create release pull request * use options instead of values * delete release version script * remove update pkg version script * create-release -> create-release-pr * chore(ci_cd): added action to create pre-release (#11216) * chore(ci_cd): added action to create pre-release * added missing extension * chore(dev): bump studio version (#11220) * chore(dev): bump studio version * chore(dev): update studio version * chore(dev): v12.26.9 (#11223) * v12.26.9 * remove dead code * update package.json in /build * chore(e2e): improve e2e tests (#5519) * chore(e2e): improve e2e tests setup * run all e2e tests * test * improved jest environment * test * should fix unit tests * test * bold tests * moved util into utils folder + added new line at end of files * small refactor * small refactor * small improvements * chore(e2e): admin tests are now working and up to date (#5772) * chore(e2e): admin tests are now working * fix logging of req & res * fix unit tests * fix collaborator admin e2e tests * refactor + fix logging after tests ended issue * should fix admin e2e auth tests * small refactor * small refactor * chore(e2e): studio tests are now working (#5774) * chore(e2e): studio tests are now working * should fix nlu e2e tests * small refactor * chore(e2e): modules tests are now working (#11205) * chore(e2e): modules tests are now working * waitFor -> waitForTimeout * fix types resolution with jest-circus * remove unnecessary code * bump studio nlu test timeout + added readme * typos * fix failing and flaky tests * make sure host is down before checking it is up when restarting server * temp test - run e2e tests on all os * should fix test failing on windows * should fix tests on mac * might fix macos tests * small fix * temporarily comment macos e2e tests * chore(dev): cleanup unused modules (#11226) * chore(dev): cron to publish next binaries (#11236) * chore(dev): cron to publish next binaries * remove dead step and checkout next branch * use ref not path * chore(dev): use single quote in workflow (#11237) * chore(dev): cron to publish next binaries * remove dead step and checkout next branch * use ref not path * chore(dev): use single quote * inputs under inputs field * use format syntax * chore(ci_cd): create draft release instead of pre release (#11224) * chore(messaging): use new http client (#11217) * use new client * fix * port * fix * fix * fix * new sync routes * admin key * bump * fix * fix * bump * move resolution * chore(deps): update dependencies (#11244) * chore(deps): update dependencies * bump trim-off-newlines * fix Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com> Co-authored-by: Francois-Xavier P. Darveau <955524+EFF@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: StephanieTremblay <94993374+StephanieTremblay@users.noreply.github.com> Co-authored-by: Yann Allard <42552874+allardy@users.noreply.github.com> Co-authored-by: Francois-Xavier P. Darveau <frxpoulin@gmail.com>
samuelmasse
added a commit
that referenced
this pull request
Jan 20, 2022
* chore(ci_cd): use gh-actions v1 (#11211) * chore(messaging): add a migration in the core to migrate messaging database (#5723) * create migration * runMessagingMigration * update version * bump messaging * bump versions * 0.0.1 migration * bot token migration * fix * fix * fix(misunderstood): strip slots for amend screen (#11214) * chore(deps): bump follow-redirects in /modules/.nlu-testing (#11212) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump follow-redirects from 1.13.1 to 1.14.7 in /modules/nlu (#11209) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump follow-redirects in /modules/channel-web (#11208) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update README.md (#5746) The links in the chat 3rd party Oauth and inter-bot communication weren't updated. So I updated them. * chore: update some libs to cover some vulns (#11215) * fix(misunderstood): strip slots for amend screen * chore: update multiple dependencies * updated translation checker script * updated translation checker script * fix(admin): create bot from template is fast again (#11218) * chore(ci_cd): added action to create release pull request (#11210) * chore(ci_cd): added action to create release pull request * use options instead of values * delete release version script * remove update pkg version script * create-release -> create-release-pr * chore(ci_cd): added action to create pre-release (#11216) * chore(ci_cd): added action to create pre-release * added missing extension * chore(dev): bump studio version (#11220) * chore(dev): bump studio version * chore(dev): update studio version * chore(dev): v12.26.9 (#11223) * v12.26.9 * remove dead code * update package.json in /build * chore(e2e): improve e2e tests (#5519) * chore(e2e): improve e2e tests setup * run all e2e tests * test * improved jest environment * test * should fix unit tests * test * bold tests * moved util into utils folder + added new line at end of files * small refactor * small refactor * small improvements * chore(e2e): admin tests are now working and up to date (#5772) * chore(e2e): admin tests are now working * fix logging of req & res * fix unit tests * fix collaborator admin e2e tests * refactor + fix logging after tests ended issue * should fix admin e2e auth tests * small refactor * small refactor * chore(e2e): studio tests are now working (#5774) * chore(e2e): studio tests are now working * should fix nlu e2e tests * small refactor * chore(e2e): modules tests are now working (#11205) * chore(e2e): modules tests are now working * waitFor -> waitForTimeout * fix types resolution with jest-circus * remove unnecessary code * bump studio nlu test timeout + added readme * typos * fix failing and flaky tests * make sure host is down before checking it is up when restarting server * temp test - run e2e tests on all os * should fix test failing on windows * should fix tests on mac * might fix macos tests * small fix * temporarily comment macos e2e tests * chore(dev): cleanup unused modules (#11226) * chore(dev): cron to publish next binaries (#11236) * chore(dev): cron to publish next binaries * remove dead step and checkout next branch * use ref not path * chore(dev): use single quote in workflow (#11237) * chore(dev): cron to publish next binaries * remove dead step and checkout next branch * use ref not path * chore(dev): use single quote * inputs under inputs field * use format syntax * chore(ci_cd): create draft release instead of pre release (#11224) * chore(messaging): use new http client (#11217) * use new client * fix * port * fix * fix * fix * new sync routes * admin key * bump * fix * fix * bump * move resolution * chore(deps): update dependencies (#11244) * chore(deps): update dependencies * bump trim-off-newlines * fix * bump messaging * fix * bump Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com> Co-authored-by: Francois-Xavier P. Darveau <955524+EFF@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: StephanieTremblay <94993374+StephanieTremblay@users.noreply.github.com> Co-authored-by: Yann Allard <42552874+allardy@users.noreply.github.com> Co-authored-by: Francois-Xavier P. Darveau <frxpoulin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove slots markdown from utterance preview in amend screen. See screen captures
Fixes botpress/studio#196
Closes BUS-106
Type of change
Before:
After
