Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): update branding assets #11248

Merged
merged 6 commits into from
Jan 24, 2022
Merged

Conversation

ptrckbp
Copy link
Contributor

@ptrckbp ptrckbp commented Jan 19, 2022

Description

Updates branding assets to match new ones in the admin panel. Corresponding PR for the studio assets is inbound. Also removes unused image. Note that the auth page logo has already been converted.

New assets :
favicon :
image
admin panel icon :
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually tested.

favicon tested under dark blue and white background conditions. It looks nicer than the black on white version.

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I've included some media (picture/gif/video) if applicable to show the old and new behavior

@laurentlp laurentlp changed the title fix(admin) update branding assets fix(admin): update branding assets Jan 19, 2022
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind my last comment, it seems like the favicons are missing when clicking Open Chat on any bot from the Admin page

Screenshot from 2022-01-19 18-04-31

@ptrckbp
Copy link
Contributor Author

ptrckbp commented Jan 21, 2022

I updated the link to the correct location (favicon now shows in "Open Chat" path) and searched for more versions of it, but couldn't find some, so I think it's solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants