Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module): we now delete old files when overwriting an existing module #11384

Merged
merged 1 commit into from
Feb 3, 2022
Merged

fix(module): we now delete old files when overwriting an existing module #11384

merged 1 commit into from
Feb 3, 2022

Conversation

laurentlp
Copy link
Contributor

@laurentlp laurentlp commented Feb 2, 2022 •
edited

This PR adds the mechanism to remove old actions and hooks that were added by a certain module when it gets overwritten.

Currently, what it does, when loading a given module, is that it deletes all its actions before adding them back. This ensures that all the actions on the disk are also on the latest archive of this module.

As for the hooks, we do something a little more "intelligent". Instead of deleting all the hooks and then adding them back. We do a diff of what is available on the disk for a given module and what is available on his archive. If there are more files on the disk than the archive, we delete those dangling hooks, otherwise, we do nothing.

It would be possible to replicate the same logic for actions, but not sure it's worth the effort.

Also, I didn't touch the content-types, but we might want to investigate if we should do the same there too.

Similar to #11371

Closes DEV-2181
Closes botpress/v12#1570

@linear
Copy link

linear bot commented Feb 2, 2022

DEV-2181 [BUG] Uploading new custom modules versions don't remove deleted module hooks/actions (botpress/botpress botpress/v12#1570)

Describe the bug
When you upload a new custom module version, if you deleted a hook/action from the module, it is not deleted from the Botpress server when you upload the new version.

To Reproduce
Steps to reproduce the behavior:

  1. Create a custom module with a hook/action
  2. Upload to the Botpress server, check if those actions/hooks were created.
  3. Create a new custom module without these hooks and upload it to the Botpress server.
  4. Check that the hook/actions were not deleted.

Expected behavior
Botpress to remove deleted files.

Environment (please complete the following information):

  • OS: [e.g. iOS, macOS, Windows]
  • Browser [e.g. Chrome, Safari]
  • Browser Version [e.g. 83.0.4103.97]
  • Botpress Version [e.g. 12.10.0]
  • NodeJS [e.g. 12.13]

botpress/borpress botpress/v12#1570 by @ davidvitora

davidvitora
davidvitora approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@davidvitora davidvitora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job

@samuelmasse samuelmasse merged commit 41c432e into master Feb 3, 2022
@samuelmasse samuelmasse deleted the llp_delete_old_module_files_when_overwriting branch February 3, 2022 19:37
This was referenced Feb 8, 2022
Closed
Closed
Merged
samuelmasse added a commit that referenced this pull request Feb 25, 2022
@samuelmasse @daehli
@ptrckbp @dependabot @laurentlp @franklevasseur @coatesap @allardy @rob-gordon @EFF @Raid55 @davidvitora @medmouine @michaelmass @github-actions
chore(cloud-staging): update runtime on cloud (#11552)
74e5d9c 
* feat(admin): added net promoter score in botpress (#11202)

* Basic NPS functionality without text tracking

feat(nps): added comment functionnality for the netpromotingscore

feat(nps): use realtime

feat(nps): use time to display the nps form

* use ms library for millisecond time

* added traduction to missing traduction

* Added Toaster and close banner when comments are added

* Created a Folder for the Net Promoter application

* Modified Prompt net promoter score

* Updates the initial delay

The three times are now confirmed with SK.

* Modified traduction in english

* fix(translation): modified one translation

Co-authored-by: Patrick <87815239+ptrckbp@users.noreply.github.com>
Co-authored-by: Samuel Massé <samuelmasse4@gmail.com>

* fix(channel-web): fetch last message for each convo (#11288)

* chore(messaging): bump to 1.0.0 (#11291)

* chore(messaging): bump to 1.0.0

* fix

* fix fix

* bump messaging

* chore(deps): bump axios from 0.21.1 to 0.21.2 in /modules/ndu (#11292)

Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](axios/axios@v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump lodash from 4.17.19 to 4.17.21 in /modules/ndu (#11295)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

---
updated-dependencies:
- dependency-name: lodash
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump axios from 0.21.1 to 0.21.2 in /modules/misunderstood (#11296)

Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](axios/axios@v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump axios from 0.21.1 to 0.21.2 in /modules/nlu (#11297)

Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](axios/axios@v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump lodash in /modules/misunderstood (#11299)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

---
updated-dependencies:
- dependency-name: lodash
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(ci_cd): enable dependabot auto deps update (#11305)

* chore(ci_cd): enable dependabot auto update

* test not publishing dependabot branches

* reverse test

* test

* test

* chore(deps): bump tar from 4.4.13 to 4.4.19 in /modules/libraries (#11306)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.13...v4.4.19)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump path-parse from 1.0.6 to 1.0.7 in /modules/libraries (#11307)

* chore(deps): bump ssri from 6.0.1 to 6.0.2 in /modules/libraries (#11310)

Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

---
updated-dependencies:
- dependency-name: ssri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump y18n from 3.2.1 to 3.2.2 in /modules/libraries (#11311)

* chore(deps): bump axios from 0.21.0 to 0.21.2 in /modules/libraries (#11301)

* chore(deps): bump hosted-git-info in /modules/libraries (#11308)

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

---
updated-dependencies:
- dependency-name: hosted-git-info
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump ini from 1.3.5 to 1.3.8 in /modules/libraries (#11312)

* chore(deps): bump ini from 1.3.5 to 1.3.8 in /modules/libraries

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

---
updated-dependencies:
- dependency-name: ini
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* use action/checkout master

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>

* chore(deps-dev): bump gulp-ignore from 2.0.2 to 3.0.0 (#11314)

Bumps [gulp-ignore](https://github.com/robrich/gulp-ignore) from 2.0.2 to 3.0.0.
- [Release notes](https://github.com/robrich/gulp-ignore/releases)
- [Commits](robrich/gulp-ignore@2.0.2...3.0.0)

---
updated-dependencies:
- dependency-name: gulp-ignore
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump nanoid from 2.1.11 to 3.1.31 in /modules/ndu (#11293)

* chore(deps): bump lodash from 4.17.20 to 4.17.21 in /modules/hitlnext (#11316)

* chore(deps): bump lodash from 4.17.19 to 4.17.21 in /modules/hitl (#11317)

* chore(deps): bump node-fetch in /modules/google-speech (#11318)

* chore(messaging): bump messaging (#11325)

* chore(dialog): detect infinite loop even when transition to error flow (#5761)

* chore(dialog): detect infinite loop even when transition to error flow

* minor fix

* clean event state when inf. loop

Co-authored-by: Samuel Massé <samuelmasse4@gmail.com>

* chore(ci_cd): remove assert pr is in shape action (#11326)

* remove code-editor as it was moved in studio@next

* update nlu to 1.0.0-rc.5

* chore(deps): update version of nanoid on dependencies (#11328)

* chore(deps-dev): bump @typescript-eslint/parser from 4.32.0 to 4.33.0 (#11331)

* chore(deps-dev): bump @types/passport from 1.0.0 to 1.0.7 (#11332)

* Update commands used to setup the dev environment (#11336)

The previous "bootstrap" command no longer exists, and "install" followed by "build" appears to be the equivalent now. Fixes #5764

* fix(code-editor): admin should be able to edit bot config (#11339)

* chore(deps): update passport-saml to latest version (#11341)

* chore(deps): update passport-saml to latest version

* update pro

* chore(deps): bump fs-extra from 9.1.0 to 10.0.0 (#11349)

* chore(deps): bump doctrine from 2.1.0 to 3.0.0 (#11348)

* chore(deps-dev): bump @types/jest-environment-puppeteer from 4.4.1 to 5.0.0 (#11350)

* fix(ui): fix 1px of whitespace issue (#11353)

* fix(id): unique ids for all elements (#11346)

* fix(id): unique ids for all elements

* chore(tests): rever test index util

* chore(tests): register when neccessary

* chore(tests): fix admin tests

* chore(tests): revert commented console.info

* chore: re-add code-editor and fix e2e tests

* chore(admin): make cloud keys required (#11338)

* chore(admin): make cloud keys required

* revert condition

* remove form validity from state

* chore(deps): bump axios from 0.21.1 to 0.21.2 in /modules/channel-web (#11357)

* chore(deps): bump copy-props from 2.0.4 to 2.0.5 (#11359)

* chore(deps): bump dot-prop from 4.2.0 to 4.2.1 in /bench (#11358)

* chore(deps): bump underscore in /modules/code-editor (#11361)

* bump messaging client

* chore(deps): bump passport-oauth2 from 1.5.0 to 1.6.1 (#11362)

* chore(deps): bump underscore from 1.9.2 to 1.13.2 (#11360)

* chore(deps): bump analytics from 0.7.18 to 0.7.21 (#11367)

* chore(deps): bump cross-env from 5.2.0 to 7.0.3 (#11366)

* chore(deps): bump express from 4.16.4 to 4.17.2 (#11365)

* chore(messaging): bump client (#11363)

* fix(builtin): added removeVariable action (#11364)

* create removeVariable action

* update tooltip docs

* fix(bot): fix unmounting bot before writing files when overwriting (#11370)

* fix(bot): we now delete old file when overwriting a bot (#11371)

* fix(bot): fix unmounting bot before writing files when overwriting

* fix(bot): we now delete old file when overwriting a bot

* feat(admin): hide workspace apps for cloud bots (#11373)

* chore(build): added a sorry file (#11372)

* chore(build): added a sorry file

* Update build/gulp.package.js

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>

* fix(core): session state not persisted during before_session_timeout hook (#5702)

* fix(core): state not persisted during

* save state in the janitor

* PR comments

* remove

Co-authored-by: Samuel Massé <samuelmasse4@gmail.com>
Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>

* chore(deps): remove unecessary dep: diff (#11392)

* fix(pipeline): fix copying copying bot in pipeline (#11391)

* fix(module): we now delete old files when overwriting an existing module (#11384)

* yarn.lock

* yarn.lock

* chore(deps-dev): bump @types/babel__core from 7.1.16 to 7.1.18 (#11402)

* chore(deps): bump querystring from 0.2.0 to 0.2.1 (#11404)

* chore(deps): remove unecessary dep: express-urlrewrite (#11406)

* chore(deps): bump react-copy-to-clipboard from 5.0.3 to 5.0.4 (#11415)

* chore(deps-dev): bump gulp from 4.0.0 to 4.0.2 (#11417)

* chore(server): bump studio and messaging (#11419)

* chore(server): bump studio and messaging

* fix messaging + added missing migration

* chore(ci_cd): add dependencies changelogs to draft release (#11408)

* chore(ci_cd): add action to close pr linked issues upon new release (#11409)

* yarn.lock

* yarn.lock

* yarn.lock

* fix(admin): fix admin debug pane not working (#11421)

* chore(deps-dev): bump prop-types from 15.7.2 to 15.8.1 (#11434)

* chore(deps): bump pg from 7.9.0 to 8.7.3 (#11433)

* chore(deps-dev): bump @types/mustache from 0.8.32 to 4.1.2 (#11432)

* chore(ci): replace actions repo by gh-actions (#11262)

* chore(dev): bring back runtime

* fix tests

* use shared typings

* update messaging and nlu endpoint

* fix packaging

* fix build scripts

* update tsconfig

* update runtime ts

* minor adjustments

* add data janitor

* add table and fix janitor

* fix build

* prebuild cmd

* update typings

* update messaging changes

* remove custom setup

* change env & cleanup script

* bring runtime changes to this branch

* cleanup

* update typings

* remove unused files

* chore(ci): github action to upload runtime docker image to private registry (#5773)

* chore(runtime): docker build

* chore(runtime): docker build

* chore(runtime): push runtime docker image to ECR

* chore(ci): fix runtime docker push github action

* chore(ci): fix runtime docker push github action

* chore(ci): fix runtime docker push github action

* chore(ci): removed unnecessary typescript & ts-node from Dockerfile-runtime

* feat(runtime): add media url support (#11207)

* add telemetry on runtime (#5751)

* replace actions repo by gh-actions

* use action directly

Co-authored-by: allardy <yann.allard1@gmail.com>
Co-authored-by: Michael Masson <10071388+michaelmass@users.noreply.github.com>
Co-authored-by: Yann Allard <42552874+allardy@users.noreply.github.com>
Co-authored-by: Samuel Massé <samuelmasse4@gmail.com>
Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>

* fix(tests): fix flaky number test (#11443)

* fix(code-editor): prevent "undefined" content in files (#11435)

* chore(e2e): increase timeout for nlu train test (#11447)

* chore(deps-dev): bump expect-puppeteer from 6.0.2 to 6.1.0 (#11438)

* fix(core): show correct status (#11449)

* fix(webchat): changing language also updates ui (#11442)

* fix(webchat): changing language also updates ui

* ensure the language is lowercase

* feat(ui): update admin screen style to match sso (#11436)

* chore(deps): bump errorhandler from 1.5.0 to 1.5.1 (#11440)

* chore(server): bump studio to v0.0.48 (#11450)

* fix e2e tests

* chore(deps): revert back to fs-extra v9 (#11452)

* chore(deps): revert back to fs-extra v9

* fix

* chore(server): release v12.26.10 (#11451)

* chore(server): release v12.26.10

* commit to be reverted

* revert last commit

Co-authored-by: laurentlp <laurentlp@users.noreply.github.com>
Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>

* chore(deps): bump analytics from 0.7.21 to 0.8.0 (#11458)

* chore(ci_cd): fix fetching changelogs in create draft release (#11455)

* yarn.lock

* chore(e2e): small overall improvements (#11463)

* chore(messaging): bump messaging (#11465)

* bump messaging-client

* bump messaging

* chore(messaging): bump messaging on runtime (#11466)

* chore(deps): bump ajv from 6.5.5 to 6.12.6 in /bench (#11467)

* chore(ci_cd): fix publishing docker images upon release (#11464)

* chore(custom-modules): Deprecate custom modules in ui-admin (#11437)

* added depr warning for custom modules

* add close callout btn, finish I18n

Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>

* chore(e2e): fix failing test (#11475)

* chore(deps): bump ajv from 6.11.0 to 6.12.6 in /modules/code-editor (#11468)

* chore(deps-dev): remove @types/chokidar (#11472)

* chore(deps-dev): remove gulp-exec (#11474)

* chore(ci_cd): remove validate doc action (#11476)

* chore(deps-dev): bump jest-puppeteer from 6.0.3 to 6.1.0 (#11473)

* yarn.lock

* chore(messaging): bump messaging (#11478)

* chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /modules/nlu (#11479)

* chore(deps): bump follow-redirects in /modules/channel-web (#11480)

* chore(deps): bump follow-redirects in /modules/misunderstood (#11489)

* chore(deps): bump follow-redirects in /modules/libraries (#11492)

* chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /modules/ndu (#11488)

* chore(deps): bump follow-redirects in /modules/bot-improvement (#11490)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump follow-redirects in /modules/hitlnext (#11491)

* chore(ci_cd): add comment when closing issues (#11477)

* chore(deps): bump style-loader from 1.3.0 to 2.0.0 (#11487)

* chore(deps-dev): bump @types/mkdirp from 1.0.1 to 1.0.2 (#11486)

* chore(deps): bump vm2 from 3.9.5 to 3.9.6 (#11498)

* chore(deps): bump webpack from 4.12.2 to 4.46.0 (#11504)

* chore(deps-dev): bump @types/jsonwebtoken from 8.3.7 to 8.5.8 (#11505)

* chore(deps): added missing nanoid dep in packages (#11497)

* chore(deps): bump @babel/preset-typescript from 7.16.0 to 7.16.7 (#11512)

* chore(deps): bump jsonlint-mod from 1.7.5 to 1.7.6 (#11513)

* chore(deps): bump getos from 3.1.1 to 3.2.1 (#11514)

* chore(pro): update pro (#11517)

* chore(ci_cd): remove unused code (#11507)

* yarn.lock

* chore(messaging): bump to 1.1.2 (#11521)

* chore(messaging): bump to 1.1.0

* env vars

* bump again

* bump client

* handle feedback

* unbump components

* chore(ci_cd): make actions compatible with dependabot (#11518)

* chore(ci_cd): make actions compatible with dependabot

* formatting

* refactor naming

* fix docker action

* small refactor

* pr comment

* chore(deps): bump url-parse from 1.5.3 to 1.5.7 (#11532)

* chore(deps): temporarily disable dependabot updates (#11534)

* bump messaging client

* yarn.lock

* fix vm2

* yarn.lock

* fix(builtin): smalltalk qnas have no contexts (#11533)

Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>

* chore(messaging): bump to 1.1.3 (#11537)

* Dynamically filled env vars for message channels (#11471)

Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>

* chore(admin): hide cloud options for pro users (#11535)

* chore(admin): hide cloud options for pro

* chore(admin): review cloud wording

* chore(admin): remove deprecation warning

* remove debug code

* Update packages/ui-admin/src/app/translations/fr.json

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>

* Update packages/ui-admin/src/app/translations/fr.json

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>

Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>

* chore(ci_cd): allow tests and build to safely run on forks (#11547)

* fix (#11549)

* fix(messaging): conversation.started skip dialog engine (#11551)

* chore(messaging): fix bump (#11550)

* chore(messaging): fix bump+

* remove auto-migrate

* fix

* fix

* fix

Co-authored-by: Daehli Nadeau Otis <daehlinadeauotis@gmail.com>
Co-authored-by: Patrick <87815239+ptrckbp@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>
Co-authored-by: Laurent Leclerc-Poulin <laurentleclercpoulin@gmail.com>
Co-authored-by: François Levasseur <francois_levasseur@hotmail.com>
Co-authored-by: Andy Coates <andy@acoates.co.uk>
Co-authored-by: Yann Allard <42552874+allardy@users.noreply.github.com>
Co-authored-by: Rob Gordon <rob.gordon@tone-row.com>
Co-authored-by: Francois-Xavier P. Darveau <955524+EFF@users.noreply.github.com>
Co-authored-by: Nick B <boutboulnicholas@gmail.com>
Co-authored-by: David Vitor Antonio <david.vitora@gmail.com>
Co-authored-by: Med Mouine <mohamed.mouine.2@ulaval.ca>
Co-authored-by: allardy <yann.allard1@gmail.com>
Co-authored-by: Michael Masson <10071388+michaelmass@users.noreply.github.com>
Co-authored-by: Rob Gordon <rchristopher.gordon@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvitora davidvitora davidvitora approved these changes

@samuelmasse samuelmasse samuelmasse approved these changes

@EFF EFF Awaiting requested review from EFF

@franklevasseur franklevasseur Awaiting requested review from franklevasseur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Uploading new custom modules versions don't remove deleted module hooks/actions
3 participants
@laurentlp @davidvitora @samuelmasse