fix(core): change default timeout #11562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlp
reviewed
Feb 25, 2022
| @@ -22,7 +22,7 @@ export interface DialogConfig { | |||
| * Interval before a session's context expires. | |||
| * e.g. when the conversation is stale and has not reached the END of the flow. | |||
| * This will reset the position of the user in the flow. | |||
| * @default 2m | |||
| * @default 25m | |||
There was a problem hiding this comment.
The bot config timeoutInterval (default to 5min) has precedence over the one on the Botpress config. See: https://github.com/botpress/botpress/blob/master/packages/bp/src/core/dialog/sessions/expiry.ts#L20
This means that changing this value will have no real effect unless you remove the default timeout from your bot configs.
There was a problem hiding this comment.
Good catch, updated that one also :)
samuelmasse
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the context timeout was 2 minutes. Meaning, if you started a conversation with the bot, then waited 3 minutes before answering it (choosing which button to click), it would start again at the beginning, forgetting your position.
From what I saw, everybody seems to change this value to something higher, so why shouldn't we put it higher by default?