fix(core): revert vm2 #11581
Merged
fix(core): revert vm2 #11581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts vm2 back to 3.9.5 (#11498)
@laurentlp Please be careful with dependabot suggestions. We must test them thoroughly. Especially core libraries like vm2. The update you merged seems to break a couple of libraries. Those are the two I normally use to test something out:
Reverting back to 3.9.5 fixes both of them
There was 1 fix two days ago because of broken stuff (3.9.6), but I tested both libraries in every version until 3.9.9 and it is still broken. Let's keep them at a working version for now. That will definitely need some tests
Maybe there is a setting or config that must be changed for that to work? I didn't see anything in the readme or changelog.