Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code-editor): minor ux issues #11598

Merged
merged 4 commits into from
Mar 16, 2022
Merged

fix(code-editor): minor ux issues #11598

merged 4 commits into from
Mar 16, 2022

Conversation

allardy
Copy link
Member

@allardy allardy commented Mar 8, 2022

Fixes 3 small issues I've encountered on the code editor:

  1. You could create .json files but couldn't delete them in the libraries section
  2. CTRL+A to select the file content was broken for files without wrapper (ex: bot config, botpress config, js files in lib section)
  3. Only adding the wrapper to .js files in the actions folder (if you create a json file, it would wrap it and it was weird)

@laurentlp
Copy link
Contributor

laurentlp commented Mar 15, 2022

@allardy Nice work, everything works as described except the last point where I still have the function wrapper with JSON files. Not sure if this is what we want?

simplescreenrecorder-2022-03-15_10.25.11.mp4

@allardy
Copy link
Member Author

allardy commented Mar 15, 2022

Good catch, that's not the wrapper but the template. Fixed :)

laurentlp
laurentlp previously approved these changes Mar 15, 2022
@EFF
Copy link
Member

EFF commented Mar 16, 2022

Doesn't seem to be related but e2e are failing. can we fix this ?

@allardy allardy merged commit bcaefe5 into master Mar 16, 2022
@laurentlp laurentlp deleted the ya-fix-code-editor branch April 1, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants