-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(channels): add channel configuration page #11646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-1628 We should regularly keep track of bots that have been deleted and unconfigure them from messaging if the were
If bots are remove but just deleting the files then they'll stay configured on messaging which isn't ideal |
samuelmasse
changed the base branch from
master
to
sm-better-messaging-communication
March 19, 2022 00:10
samuelmasse
changed the base branch from
sm-better-messaging-communication
to
master
March 22, 2022 20:02
laurentlp
reviewed
Mar 23, 2022
packages/bp/src/migrations/v12_26_12-1652113636-bump_messaging.ts
Outdated
Show resolved
Hide resolved
laurentlp
approved these changes
Mar 26, 2022
This was referenced Apr 7, 2022
This was referenced Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a channel configuration page in the admin. Also adds bp.messaging to the sdk to provide http clients to make calls to messaging
Bumps messaging to 1.1.6 and adds a migration
Todo in future PRs
Closes DEV-1628
Closes DEV-2474