Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(channels): add channel configuration page #11646

Merged
merged 46 commits into from
Mar 28, 2022
Merged

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Mar 19, 2022

Adds a channel configuration page in the admin. Also adds bp.messaging to the sdk to provide http clients to make calls to messaging

Bumps messaging to 1.1.6 and adds a migration

Todo in future PRs

  • Should not show the telegram webhook (or show it with / at the end)
  • Add channel version field, and switch between legacy and v1 channels
  • Improve fields validation, add checkboxes and textarea
  • Add a way to delete a leftover channel configuration (when a bot is deleted)
  • Add a way to create channel configurations without a bot
  • Add a way to rename channel configurations
  • Stream health events to the UI for debugging

Closes DEV-1628
Closes DEV-2474

@linear
Copy link

linear bot commented Mar 19, 2022

DEV-1628 We should regularly keep track of bots that have been deleted and unconfigure them from messaging if the were

If bots are remove but just deleting the files then they'll stay configured on messaging which isn't ideal

@samuelmasse
Copy link
Contributor Author

Looks like this at the moment. You can configure channels for any botId. The bot id doesn't have to match an existing botId, but when it does incoming messages will be responded by that bot. This will allow transfering channel configurations from bot config to global configurations (which they are)
Screenshot from 2022-03-18 20-07-25

@samuelmasse samuelmasse changed the base branch from master to sm-better-messaging-communication March 19, 2022 00:10
@samuelmasse samuelmasse changed the base branch from sm-better-messaging-communication to master March 22, 2022 20:02
@laurentlp laurentlp marked this pull request as ready for review March 23, 2022 17:32
@samuelmasse samuelmasse merged commit e85bb34 into master Mar 28, 2022
@samuelmasse samuelmasse deleted the sm-channels-page branch March 28, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants