-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): fix testing module not working #11687
fix(testing): fix testing module not working #11687
Conversation
DEV-2365 (BUG) Testing module not save scenarios (botpress/botpress botpress/v12#1610)
Describe the bug To Reproduce
Expected behavior Console output
Environment (please complete the following information):
Additional context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I was able to record a test and run it.
This PR basically fixes the recording and running part of the testing module.
Since we made changes to the channel-web and uses this module to record scenarios, I had to fetch the user mapping so we can properly validate the event target. Also, instead of using the channel web when running the scenario, we now use an imaginary testing module (hopefully no one uses the testing channel as a real module)!
I will convert the JSX files in another PR.
Closes botpress/v12#1610