Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): configure botpress user for the docker image #11937

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

laurentlp
Copy link
Contributor

@laurentlp laurentlp commented Jul 6, 2022

This PR adds the config to set and use the Botpress user inside the Dockerfile.

It also adds a warning in case a user is running Botpress as a privileged user:

Screenshot from 2022-07-13 11-11-14

Related PR: botpress/documentation#76

@laurentlp laurentlp requested a review from EFF July 6, 2022 15:48
build/docker/Dockerfile Outdated Show resolved Hide resolved
build/docker/Dockerfile Outdated Show resolved Hide resolved
build/docker/Dockerfile Outdated Show resolved Hide resolved
@laurentlp laurentlp marked this pull request as ready for review July 6, 2022 15:50
EFF
EFF previously approved these changes Jul 7, 2022
Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We might want to get a 2nd pair of 👀 just to make sure we're good

@laurentlp laurentlp changed the title chore(docker): configure botpress user for the docker image feat(docker): configure botpress user for the docker image Jul 7, 2022
@laurentlp laurentlp marked this pull request as draft July 11, 2022 22:10
@laurentlp laurentlp marked this pull request as ready for review July 12, 2022 21:44
@laurentlp laurentlp requested a review from sebburon July 12, 2022 21:44
@laurentlp laurentlp requested a review from EFF July 13, 2022 15:13
@slvnperron
Copy link
Member

Code looks good to me, but i think we should double check with Mike, David and/or Seb if this could impact existing deployments?

@slvnperron slvnperron self-requested a review July 20, 2022 18:53
Copy link
Contributor

@davidvitora davidvitora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentlp laurentlp merged commit b5b6492 into master Jul 22, 2022
@laurentlp laurentlp deleted the llp_improve_docker_image branch July 22, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants