-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): configure botpress user for the docker image #11937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We might want to get a 2nd pair of 👀 just to make sure we're good
Code looks good to me, but i think we should double check with Mike, David and/or Seb if this could impact existing deployments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds the config to set and use the Botpress user inside the Dockerfile.
It also adds a warning in case a user is running Botpress as a privileged user:
Related PR: botpress/documentation#76