Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(basic-skills): reused choice will not start with fresh variables #11949

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

davidvitora
Copy link
Contributor

@davidvitora davidvitora commented Jul 7, 2022

This fixes an issue where, if you enter in the same choice skill more than once, you might face unexpected behavior because the variables used by the choice would not be reset.

Example:

Flow:
image
image
image

Before:
image

After:
image

Bot:
bot_choice-skill_1657224116110.zip

@davidvitora davidvitora marked this pull request as draft July 7, 2022 19:47
@davidvitora davidvitora requested a review from allardy July 7, 2022 20:03
@davidvitora davidvitora assigned laurentlp and unassigned laurentlp Jul 7, 2022
@davidvitora davidvitora self-assigned this Jul 7, 2022
@davidvitora davidvitora marked this pull request as ready for review July 7, 2022 20:05
@davidvitora davidvitora requested a review from EFF July 8, 2022 13:59
@davidvitora davidvitora merged commit 93b3fc0 into master Jul 20, 2022
@davidvitora davidvitora deleted the fix_choice_skill branch July 20, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants