Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): log the user out when account is locked out on pass change #11997

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

laurentlp
Copy link
Contributor

This PR fixes an issue where the user was not logged out when trying to update his password with the wrong current password too many times.

When maxLoginAttemps is set, we lock an account in case of multiple unsuccessful login attempts in a row. If this happens on the admin when the user updates his password, it makes sense to log the user out and invalidate his token.

before

simplescreenrecorder-2022-07-18_16.21.42.mp4

after

simplescreenrecorder-2022-07-18_16.18.20.mp4

Copy link
Member

@slvnperron slvnperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@laurentlp laurentlp merged commit 5ba4d32 into master Jul 18, 2022
@laurentlp laurentlp deleted the llp_fix_account_lockout_on_pass_change branch July 18, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants