-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): fix passing env vars to running shell #12051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me, I assume you tested and works.
@sebburon @bassamtantawi-botpress @davidvitora given the history of this one 😆 can you guys please have a look at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Container failed when running with
sudo docker run -d \
--name=container_name \
-p 3000:3000 \
ghcr.io/botpress/botpress/server:llp_fix_docker_image_env_vars \
bash -c "./duckling & ./bp --auto-migrate"
I got an error when running creating the container; I am using my old command to execute Botpress
…cker_image_env_vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the latest changes, it's working correctly
Currently testing this on an AWS Hosted cluster. |
it is working for me too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on AWS and it works
This PR fixes an issue where environment variables were not passed to the shell when starting the Docker container. To fix the issue, we now propagate the env vars so that a user starting the container with
-e
arguments will see his variables passed to the Botpress binary.