feat(hitlnext): Adds spanish language support #12056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
EFF
reviewed
Aug 3, 2022
There was a problem hiding this comment.
@charlyR, thank you for submitting this pr, good work.
I left 2 comments for you, please review and address changes if necessary.
please also make sure to sign our contributor license agreement in order for us to approve these changes
| @@ -16,7 +16,7 @@ import UserName from './UserName' | |||
|
|
|||
| const HandoffItem: FC<IHandoff> = ({ createdAt, id, status, agentId, userConversation, userChannel, user }) => { | |||
| const { state, dispatch } = useContext(Context) | |||
|
|
|||
| moment.locale(lang.getLocale()) | |||
There was a problem hiding this comment.
This is to instruct moment to display elapsed time in the selected language. In spanish it is "dias", "horas", "segundos"
I think the same apply to other languages.
modules/hitlnext/src/views/full/studio-sidebar/components/HandoffItem.tsx
Outdated
Show resolved
Hide resolved
EFF
changed the title
|
I have already signed the CLA, but stills appears as pending... |
laurentlp
reviewed
Aug 9, 2022
laurentlp
approved these changes
Aug 9, 2022
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitlnext language currently supports only english and french language.
I have added support for spanish language, and moment date translation to user language.