Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): only Super Admins can reboot the server #12100

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix(security): only Super Admins can reboot the server #12100

merged 1 commit into from
Aug 25, 2022

Conversation

laurentlp
Copy link
Contributor

@laurentlp laurentlp commented Aug 25, 2022 •
edited
Loading

This PR improves the security by only allowing the Super Admins to reboot the server.

To test:

  • First, run this branch.
  • Then create an admin, a developer, a content editor, or an agent.
  • Login as the user and fetch its token
  • Make a POST call to http://localhost:3000/api/v1/admin/server/rebootServer using the token to authenticate and see the 403 error code returned.

@laurentlp laurentlp requested a review from EFF August 25, 2022 19:02
EFF
EFF approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@laurentlp laurentlp merged commit 39e2e0f into master Aug 25, 2022
@laurentlp laurentlp deleted the llp_only_sa_can_reboot branch August 25, 2022 19:24
This was referenced Aug 25, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EFF EFF EFF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laurentlp @EFF