Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): upgrade ioredis to fix cluster #12299

Merged
merged 1 commit into from Dec 22, 2022
Merged

Conversation

davidvitora
Copy link
Contributor

@davidvitora davidvitora commented Nov 21, 2022

We need to update the version of ioredis in order to fix the following issue when using Redis Cluster.

REDIS_URL=[{"host": "192.168.100.7", "port": "7000"}, {"host": "192.168.100.7", "port": "7001"}, {"host": "192.168.100.7", "port": "7002"}, {"host": "192.168.100.7", "port": "7003"}, {"host": "192.168.100.7", "port": "7004"}, {"host": "192.168.100.7", "port": "7005"}]
CLUSTER_ENABLED=true

Before:

image

After:

image
image

If we use the old version, the server never gets initialized and gets stuck in a cluster connection loop.

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
botpress-v12-docs ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 10:46PM (UTC)

@davidvitora davidvitora requested review from EFF and removed request for EFF November 21, 2022 22:48
@davidvitora davidvitora marked this pull request as draft November 21, 2022 22:52
@davidvitora davidvitora requested a review from EFF December 21, 2022 16:21
@davidvitora davidvitora marked this pull request as ready for review December 21, 2022 16:35
Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@davidvitora davidvitora merged commit 416eb49 into master Dec 22, 2022
@davidvitora davidvitora deleted the fix_redis_cluster branch December 22, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants