New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-shared): shared component library #2954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally we'll have a shared UI library :) Good job !
This reverts commit 3bd53d1.
@@ -93,6 +86,7 @@ function addDialog(props, resolve) { | |||
const div = document.createElement('div') | |||
|
|||
div.setAttribute('id', 'confirmDialog-container') | |||
div.setAttribute('class', styles.ConfirmDialogContainer) | |||
body.appendChild(div) | |||
|
|||
ReactDOM.render(<ConfirmDialogComponent {...props} resolve={resolve} />, div) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a good candidate for the next shared component: https://github.com/botpress/botpress/blob/master/src/bp/ui-admin/src/Pages/Components/BaseDialog.tsx
Since we always use the same boilerplate for dialogs, we have a base component with our preferred default props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, we're good to go !
No description provided.