Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hitl2): shortcuts #4315

Merged
merged 17 commits into from
Jan 8, 2021
Merged

feat(hitl2): shortcuts #4315

merged 17 commits into from
Jan 8, 2021

Conversation

phildionne
Copy link
Contributor

@phildionne phildionne commented Dec 15, 2020

Implements the slash command pattern to quickly insert a pre-configured text from a shortcut.

Inspired by #3555

@phildionne phildionne self-assigned this Dec 15, 2020
@allardy
Copy link
Member

allardy commented Dec 15, 2020

Please avoid prefixing your interfaces with I. Typings are already there, no need to hint what it is...

@phildionne
Copy link
Contributor Author

@EFF The autocomplete injection into composer works, but I need a reference to bp in order to make an API call and I'm really not sure how to handle that. See https://github.com/botpress/botpress/pull/4315/files#diff-ef62125283a4bd1b54fb4d09bb28481d7e8ca1aa78572dd8f56b8720ccc2928fR11

I think you jumping in would be best!

@EFF EFF changed the title feat(hitl2) Slash commands / autocomplete feat(hitl2): shortcuts Jan 8, 2021
@EFF EFF marked this pull request as ready for review January 8, 2021 02:49
Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested quite extensively and did a few changes

@EFF EFF merged commit 54068b6 into master Jan 8, 2021
@EFF EFF deleted the pd_hitlnext_slash branch January 8, 2021 12:52
@EFF EFF mentioned this pull request Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants