fix(nlu): no more weird debounce that override other intents #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EFF
previously approved these changes
Dec 16, 2020
| train: () => Promise<void> | ||
| cancelTraining: () => Promise<void> | ||
| } | ||
| export type NLUApi = ReturnType<typeof makeApi> |
There was a problem hiding this comment.
By doing this, you loose all the typing for return types .. we can move the return types in the impl istead
There was a problem hiding this comment.
ahhh that's why it was so dupplicated
sure then I'll do this
franklevasseur
commented
Dec 16, 2020
| liteEditor?: boolean | ||
| } | ||
|
|
||
| export const IntentEditor: FC<Props> = props => { | ||
| const [intent, setIntent] = useState<NLU.IntentDefinition>() | ||
|
|
||
| const debouncedApiSaveIntent = useRef( | ||
| _.debounce((newIntent: NLU.IntentDefinition) => props.api.createIntent(newIntent), 2500) |
franklevasseur
commented
Dec 16, 2020
| useEffect(() => { | ||
| // tslint:disable-next-line: no-floating-promises | ||
| props.api.fetchIntent(props.intent).then(intent => { | ||
| setIntent(intent) | ||
| utils.inspect(intent) | ||
| }) | ||
|
|
||
| return () => debouncedApiSaveIntent.current.flush() |
There was a problem hiding this comment.
this is also the fix
franklevasseur
commented
Dec 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing botpress/v12#1185 + added few typings while I was there.
I'm not sure I actually solved the problem described in the issue, but I solved another one for sure:
when swicthing between intents (in the left pannel), if you switch before 2.5 seconds of deboucing, you override the current intent.
this is fixed now.