Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hitlnext): Infinite loading of the agent live chat #4550

Merged
merged 1 commit into from Mar 2, 2021
Merged

fix(hitlnext): Infinite loading of the agent live chat #4550

merged 1 commit into from Mar 2, 2021

Conversation

sebburon
Copy link
Contributor

Livechat was stuck in a loading loop when the EXTERNAL_URL was set with a subdir at the end.

Before:
Screen Shot 2021-02-25 at 3 29 23 PM

After:
Screen Shot 2021-02-25 at 3 31 45 PM

This issue could also be resolved by removing completely the line I edited

@sebburon sebburon marked this pull request as ready for review February 25, 2021 21:11
Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is window.ROOT_PATH set ?

I can. see that in some installation of ours window.ROOT_PATH is empty string

Copy link
Member

@allardy allardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! Thanks

@sebburon
Copy link
Contributor Author

sebburon commented Mar 1, 2021

Where is window.ROOT_PATH set ?

I can. see that in some installation of ours window.ROOT_PATH is empty string

--How I came up with window.ROOT_PATH and why this line can also be deleted:

modules/channel-web/assets/inject.js line91
const host = config.host || window.ROOT_PATH || ''

--Where window.ROOT_PATH is set:
src/bp/core/server.ts line442

replace(/ROOT_PATH=""|ROOT_PATH = ''/, window.ROOT_PATH="${process.ROOT_PATH}")

@EFF EFF merged commit bf92ebf into botpress:master Mar 2, 2021
@EFF EFF mentioned this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants