fix(migrations): proper migration for tokenVersion #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add a comment as to why we have duplicated this migration so that there is no confusion in the future? |
|
@laurentlp I was thinking thinking that people would find a way to this PR through the Git blame. Do you think that would be enough? I can also add the comment if necessary. |
EFF
requested changes
Mar 15, 2021
|
did it for you. thanks : 🙏 |
EFF
approved these changes
Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a copy of
src/bp/migrations/v12_17_1-1611946378-implement_token_version.tsbut with av12_18_3prefix.This fixes a bug where the
v12_17_1-1611946378-implement_token_version.tsmigration was mistakenly distributed in 12.18.0. As a result, thev12_17_1-1611946378-implement_token_version.tswas never run if you migrated from >= 12.17.1 to 12.18.0.Adding a copy of this migration in the 12.18.3 release will ensure the migration will be run for clients who migrate to 12.18.3.