Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webchat): typo in createConversation #4725

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(webchat): typo in createConversation #4725

merged 1 commit into from
Mar 19, 2021

Conversation

spg
Copy link
Member

@spg spg commented Mar 19, 2021

There was a structure mismatch between the data returned by the server and the format expected by the frontend

This causes in infinite loop (create new conversation -> list conversations -> create new conversation -> ...) in the webchat if the oldest conversation has last_heard_on=null (i.e. if no user has interacted with the bot, like for new bots) and startNewConvoOnTimeout=true in the webchat config.

@spg spg merged commit fabe1fc into master Mar 19, 2021
@spg spg deleted the spg-fix-webchat branch March 19, 2021 18:35
@EFF EFF mentioned this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants