Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code): fix for CVE-2020-7743 #4833

Merged
merged 2 commits into from
Apr 22, 2021
Merged

fix(code): fix for CVE-2020-7743 #4833

merged 2 commits into from
Apr 22, 2021

Conversation

sebburon
Copy link
Contributor

fix for CVE-2020-7743

This was done by doing a yarn upgrade mathjs @^7.5.1 in 2 places:

  • /botpress
  • /botpress/modules/nlu

@sebburon sebburon requested review from EFF, laurentlp and spg April 12, 2021 15:33
@sebburon sebburon marked this pull request as ready for review April 12, 2021 15:49
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure there is no breaking changes between 5.9.0 and 7.5.1?

@sebburon
Copy link
Contributor Author

Are you sure there is no breaking changes between 5.9.0 and 7.5.1?

Yes, there are some breaking changes for 6.0.0 and 7.0.0 but from what I can see, nothing that affects the product.
Here are the changes:

6.0.0: https://mathjs.org/history.html#20200507-version-700
7.0.0: https://mathjs.org/history.html#20190608-version-600

laurentlp
laurentlp previously approved these changes Apr 12, 2021
@EFF EFF merged commit 543d830 into botpress:master Apr 22, 2021
@EFF EFF mentioned this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants