fix(channel-web): fix useSessionStorage config option

[laurentlp]

This PR fixes as an issue where setting useSessionStorage to true with the webchat would not store the information in the sessionStorage as it should.

• The storage utility now allows changing storage driver when the value of window.USE_SESSION_STORAGE changes.

• Since the storage is initialized before the value of window.USE_SESSION_STORAGE is set, we have to re-setup the EventBus in order for it to store the socket id in the sessionStorage.

• Adds missing typings

• Tests were added here: chore(shared-lite): added unit tests for storage utils #5405

See botpress/studio#22 for more details

[EFF]

I've got a few questions, let me know it it's not clear .

[samuelmasse]

Nice work on the fix 👍 When I set useSessionStorage to true I don't get the same conversation back when closing my browser.

I think for the implementation that it would be better to only setup the socket once if useSessionStorage is passed to true in the init() function of the webchat. There seems to be a problem for example with bp/channel-web/user-lang. It gets set in the local storage at first and I need to refresh the page to have it in the session storage.

Aside from this fix I think we can merge this. I put some comments mostly to get some clarifications on the changes but they don't require changing anything

[samuelmasse]

LGTM

[allardy]

As discussed, I don't think useSessionStorage should be modified after the webchat was initialized. Changing the storage means we should clear the local storage, then reload the whole page using the chosen storage. It should be chosen when the webchat is initialized only.

Currently, we load the webchat twice if useSessionStorage is enabled. Changes to the event bus & reloading of data when that property is changed just adds useless complexity

The storage lib of ui-shared is used in the studio and in some modules, while the window.USE_SESSION_STORAGE property is only handled by the webchat (in ui-lite), so changes made in the studio aren't used anywhere.

I think it could make sense to move that property in the botpress configuration file, but to keep it simple for now, just set useSessionStorage when the webchat is initialized, and log a warning if it is passed to botpressWebChat.configure

[laurentlp]

As discussed, I don't think useSessionStorage should be modified after the webchat was initialized. Changing the storage means we should clear the local storage, then reload the whole page using the chosen storage. It should be chosen when the webchat is initialized only.

Changes were made and 'useSessionStorage' can only be configured once during the webchat initialization. If you try to re-configure this value calling configure, a warning is print in the console that tells you the value cannot be altered.

[allardy]

LGTM