feat(nlu): nlu cloud configuration #5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(nlu): nlu cloud configuration * fix(build): remove bpd * fix(build): fix Docker build * Add workspace workflow * fix(nlu): added module moment & fixed cloud client * fix(bot): don't wait for STUDIO_READY * feat(messaging): messaging cloud configuration (#5261) * first draft * disable waiting for studio Co-authored-by: Simon-Pierre Gingras <892367+spg@users.noreply.github.com> * fix(core): remove STUDIO_READY (#5262) * fix(core): remove STUDIO_READY * Forgot this Co-authored-by: Simon-Pierre Gingras <892367+spg@users.noreply.github.com> Co-authored-by: Laurent Leclerc Poulin <laurentlp@users.noreply.github.com>
spg
previously approved these changes
Aug 12, 2021
|
Let's take @franklevasseur's input |
franklevasseur
previously approved these changes
Aug 19, 2021
| @@ -0,0 +1,43 @@ | |||
| import { Locker } from './lock' | |||
|
|
|||
| describe('getLock', () => { | |||
franklevasseur
approved these changes
Aug 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies NLU Client in case there is a cloud field in bot config
The client now appends a proper auth token to all calls