Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared-lite): added unit tests for storage utils #5405

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

laurentlp
Copy link
Contributor

This PR adds some kind of testbed for ui-shared-lite and adds unit tests for the storage utility.

@laurentlp laurentlp changed the title chore(sharedLite): added unit tests for storage utils chore(shared-lite): added unit tests for storage utils Sep 3, 2021
Copy link
Contributor

@samuelmasse samuelmasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentlp laurentlp merged commit bfec49f into llp_fix_session_storage Sep 8, 2021
@laurentlp laurentlp deleted the llp_session_storage_tests branch September 8, 2021 20:50
laurentlp added a commit that referenced this pull request Sep 16, 2021
* fix(channel-web): fix useSessionStorage config option

* small fix

* merge master

* fix using session storage

* fix build

* reject with error when visutor id cannot be acquired

* added missing typings

* added automatic serialize and deserialize when using storage utils class

* callers now use storage own serialize + deserialize

* small fix

* pr comments

* update locale with config + setup socket only once on init

* chore(shared-lite): added unit tests for storage utils (#5405)

* chore(sharedLite): added unit tests for storage utils

* fix build

* updated unit tests

* removed ability to reconfigure useSessionStorage

* removed unecessary async/await

* better typings

* PR comments + bump studio v0.0.37

Co-authored-by: Samuel Massé <59894025+samuelmasse@users.noreply.github.com>
@EFF EFF mentioned this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants