Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(channel-web): down mig drop all msg_ tables #5452

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

samuelmasse
Copy link
Contributor

The migration didn't clean up tables created by the messaging server after the migration was run. So now it deletes all tables with a name beginning with msg_

Closes DEV-1819

@linear
Copy link

linear bot commented Sep 14, 2021

Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment other than that, tested with both SQLite and PG using a superuser and db owner, and LGTM!

@samuelmasse samuelmasse merged commit 6f03d1c into master Sep 15, 2021
@samuelmasse samuelmasse deleted the sm-fix-migration-drop-all-tables branch September 15, 2021 18:47
@EFF EFF mentioned this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants