Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add small safeguards #5459

Merged
merged 1 commit into from
Sep 17, 2021
Merged

fix(core): add small safeguards #5459

merged 1 commit into from
Sep 17, 2021

Conversation

allardy
Copy link
Member

@allardy allardy commented Sep 17, 2021

Two minor fixes for situations that should usually not happen in happy paths.
image

disabling all modules causes this
image

laurentlp
laurentlp approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@allardy allardy merged commit a1a83c8 into master Sep 17, 2021
@laurentlp laurentlp mentioned this pull request Sep 17, 2021
Merged
@laurentlp laurentlp deleted the ya-fix-qna branch September 17, 2021 17:05
@EFF EFF mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlp laurentlp laurentlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allardy @laurentlp