Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): show when env variable is set #5625

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

sadda11asm
Copy link
Contributor

@sadda11asm sadda11asm commented Nov 1, 2021

Description

Now it is shown in the production checklist when env variable BP_CONFIG_PRO_ENABLED and BP_CONFIG_PRO_LICENSEKEY are set via env variables
Fixes botpress/v12#1490

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Set env variable and see if it is shown
  • Delete env variable and see if it is not shown

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I've included some media (picture/gif/video) if applicable to show the old and new behavior

@sadda11asm sadda11asm changed the base branch from master to x-meta November 1, 2021 15:19
Copy link
Member

@allardy allardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadda11asm sadda11asm merged commit 4b1ca70 into x-meta Nov 1, 2021
@franklevasseur franklevasseur mentioned this pull request Nov 3, 2021
This was referenced Dec 2, 2021
@samuelmasse samuelmasse deleted the fix-env-not-shown branch January 28, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]:Production check list doesn't display the right information in the Botpress Pro section
2 participants