Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webchat): mic icon overlaid on button #5626

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

spg
Copy link
Member

@spg spg commented Nov 1, 2021

Description

https://linear.app/botpress/issue/DEV-1833/[bug]-web-channel-microphone-button-is-layered-below-the-send-button

Fixes botpress/v12#1482

Before:

Screen Shot 2021-11-01 at 11 12 17 AM

After:

Screen Shot 2021-11-01 at 11 13 38 AM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore change (refactoring and / or test changes)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing
  • Test B

Test configuration:

  • BP version:
  • Node version:
  • OS:
  • Browser:
  • Binary or source ?:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I've included some media (picture/gif/video) if applicable to show the old and new behavior

@linear
Copy link

linear bot commented Nov 1, 2021

DEV-1833 [BUG] Web-Channel Microphone button is layered below the send button (botpress/borpress botpress/v12#1482)

Describe the bug
After changing the bot injection script to enable the "enableVoiceComposer" and applying it, then the Microphone button is layered below the normal "Send Message" button.

So we can't click it till we inspect the HTML and hide the "Send Message" button, or change the order of the "Microphone" button.

To Reproduce
Change the injection script, and enable the "enableVoiceComposer". Click "Apply". Check the "Microphone" button that has just appeared.

Expected behavior
To be able to click the button

Screenshots
image

Environment (please complete the following information):
-Botpress v12.26.1

botpress/borpress botpress/v12#1482 by @ bassamtantawi-botpress

Copy link
Contributor

@davidvitora davidvitora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spg spg merged commit b3955fe into x_party-parrots Nov 1, 2021
@spg spg deleted the spg-dev-1833 branch November 1, 2021 17:11
This was referenced Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants