Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug of allowing user to send more than the max utterance length #5633

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

mallorbc
Copy link
Contributor

@mallorbc mallorbc commented Nov 1, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # botpress/v12#1445

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore change (refactoring and / or test changes)

How has this been tested?

Manual testing through

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test configuration:

  • BP version:
  • Node version:
  • OS:
  • Browser:
  • Binary or source ?:

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I've included some media (picture/gif/video) if applicable to show the old and new behavior

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ slvnperron
❌ mallorbc
You have signed the CLA already but the status is still pending? Let us recheck it.

@slvnperron slvnperron merged commit 1f18201 into x_segfault Nov 1, 2021
This was referenced Dec 2, 2021
@samuelmasse samuelmasse deleted the x_segfault_blakem branch January 28, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants