fix(1002): make embed chat icon less weird in iframe #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-1002 (BUG) Style applied during loading - channel-web (botpress/botpress botpress/v12#1000)
When a bot is loaded on a web page, depending on loading speed and page load, the "Chat window" title text may be visible before the default or custom button is shown, or other styling issues where it looks like some is applied before others. Steps to reproduce the behaviour:
Example, see frames 55 to 65 of this gif: Expected behaviour: Environment:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes DEV-1002
Issue
Now looks like this instead. Not perfect but the execution flow as well as accessing the specific stylesheet is a bit complicated in an obscure React component as well as it being injected into an iframe.
