-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): partial fix for bp push #5652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment to side-effects, because it will take too much time, but code wise, there's no issue. It builds, and it runs! Maybe good enough for a bug-fixing marathon.
DEV-1966 [BUG] "!builtin_text-" not found after bp push (botpress/borpress botpress/v12#1535)
Describe the bug I get a response from the There also is an error in the logs
To Reproduce
Expected behavior Screenshots Environment (please complete the following information):
Additional context I'd also add that:
|
Description
This is a temporary PR which will fix the related issue but will still need refining / a proper fix. Basically, when we use bp push, we overwrite the remote files with the local ones, then we unmount remote bots, and mount the new bots.
The problem here is that the unmount operation was not entirely completed before it tries to mount it, I suspect there's a conflict somewhere between the studio and the core. A workaround for the associated issue is to run the bp push command twice. This fix will remove that requirement.
Since we plan to separate the studio from the core really soon, I don't think much more time should be put here
Fixes #https://linear.app/botpress/issue/DEV-1966/[bug]-builtin-text-not-found-after-bp-push-botpressborpress-5643
Fixes DEV-1966
Type of change
Please delete options that are not relevant.