-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(channel-web): display feedback actions on all q&a answers #5662
fix(channel-web): display feedback actions on all q&a answers #5662
Conversation
DEV-1162 [BUG] QnA Thumbs Up & Down (botpress/botpress botpress/v12#1160)
Is your feature request related to a problem? Please describe. Describe the solution you'd like Describe alternatives you've considered Additional context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure that your PR description follows the conventional commit nomenclature!
Otherwise, I have small minor comments but overall I tested it and it looks fine to me. Nice work!
modules/channel-web/src/views/lite/components/messages/MessageGroup.tsx
Outdated
Show resolved
Hide resolved
modules/channel-web/src/views/lite/components/messages/MessageGroup.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Successfully tested using commit 6642d74 Test Steps
|
Description
feedback on lastMessages
events table
to prevent displayingfeedbacks on every QnA answers
(see image below)Media (how it feels like now)
Screen.Recording.2021-11-03.at.8.16.51.AM.mov
Fixes # botpress/v12#1160
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test configuration:
Checklist: