feat(misunderstood): add support for all types of messages #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2077 [FEATURE] Misunderstood - Custom component support
We currently don't support custom component in the ui messages. Who ever is going to work on this, custom components are located in the window element. |
laurentlp
commented
Dec 2, 2021
modules/misunderstood/src/views/full/MainScreen/ChatPreview.tsx
Outdated
Show resolved
Hide resolved
| border: 1px solid #ccc; | ||
|
|
||
| p { | ||
| margin: 0; |
There was a problem hiding this comment.
Somehow bootstrap was adding a margin to the p element that was causing the text inside each bubbles to be wrongly aligned.
laurentlp
force-pushed
the
llp_misunderstood_use_messaging_components
branch
from
3fa526e
to
53a4ee7
Compare
1 task
laurentlp
changed the title
samuelmasse
previously approved these changes
Dec 6, 2021
Comment on lines
+25
to
+28
| // TODO: Add translation and move this logic into the @botpress/messaging-components lib | ||
| if (message.type === 'session_reset') { | ||
| return <div className={style.chatPreviewMessage_System}>Reset the conversation</div> | ||
| } |
There was a problem hiding this comment.
Is this todo still valid?
There was a problem hiding this comment.
@samuelmasse I think so. It might be nice to have a way to display conversation reset using the library. What do you think?
samuelmasse
approved these changes
Dec 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for all types of messaging to the misunderstood module by using the
@botpress/messaging-componentslibrary.Closes DEV-2077
Type of change
Missing
Screenshots