-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hitl): add support for all types of messages #5736
Conversation
DEV-2076 [BUG]: HITL Not Rendering Choice, Dropdown and Custom Components (botpress/botpress botpress/v12#1350)
Description To Reproduce Expected Behavior Environment
Additional Context These two critical functionalities (monitoring and take-over) are vital for maintaining a low chatbot churn, understanding user behaviour and identifying workflows which can be improved. As such I feel that the HITL module remains relevant until the HITLNext module incorporates these functionalities. |
"bluebird": "^3.5.3", | ||
"classnames": "^2.2.6", | ||
"csstype": "^2.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise it would use csstype@3
installed by @emotion/serialize
@@ -243,7 +243,7 @@ | |||
} | |||
|
|||
.bph-chat-bubble { | |||
max-width: 60%; | |||
max-width: 50%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to change this value for the carousel to be properly rendered. It would otherwise overflow and cause the chat to have a horizontal scrollbar.
Not sure if this issue comes from the component itself or simply that it requires the module to adapt its CSS!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working 👍
// TODO: Visit and session reset are currently unsupported by @botpress/messaging-components | ||
if (type === 'visit') { | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we even display those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be relevant for the agent, knowing when was the last time a user visited the bot.
Description
This PR adds support for all types of messages to the HITL module by using the @botpress/messaging-components library.
Similar to: #5731
Fixes botpress/v12#1350
Closes DEV-2076
Type of change
Recording
simplescreenrecorder-2021-12-02_14.58.29.mp4