Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hitl): add support for all types of messages #5736

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

laurentlp
Copy link
Contributor

Description

This PR adds support for all types of messages to the HITL module by using the @botpress/messaging-components library.

Similar to: #5731

Fixes botpress/v12#1350
Closes DEV-2076

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Recording

simplescreenrecorder-2021-12-02_14.58.29.mp4

@linear
Copy link

linear bot commented Dec 2, 2021

DEV-2076 [BUG]: HITL Not Rendering Choice, Dropdown and Custom Components (botpress/botpress botpress/v12#1350)

Description
All content elements except text are not rendered in HITL interface meaning agents miss some parts of the conversation. This is not the case with HITL Next but HITLNext has the disadvantage that you can only view chats of users who have requested for the intervention of an agent.

To Reproduce
Converse with a bot which has these content elements and check the conversation from the HITL Interface.

Expected Behavior
Messages from both the chatbot and the user should be rendered as they appeared in the chat.

Screenshots
image

Environment

  • OS: [Windows]
  • Browser [Chrome]
  • Browser Version [90.0.4430.212]
  • Botpress Version [12.21.0]
  • NodeJS [12.13]

Additional Context
The HITL module is the only module which allows monitoring of conversations in progress. It also allows an agent to initiate the takeover process by providing a pause button.

These two critical functionalities (monitoring and take-over) are vital for maintaining a low chatbot churn, understanding user behaviour and identifying workflows which can be improved. As such I feel that the HITL module remains relevant until the HITLNext module incorporates these functionalities.

"bluebird": "^3.5.3",
"classnames": "^2.2.6",
"csstype": "^2.2.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it would use csstype@3 installed by @emotion/serialize

@@ -243,7 +243,7 @@
}

.bph-chat-bubble {
max-width: 60%;
max-width: 50%;
Copy link
Contributor Author

@laurentlp laurentlp Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change this value for the carousel to be properly rendered. It would otherwise overflow and cause the chat to have a horizontal scrollbar.

Not sure if this issue comes from the component itself or simply that it requires the module to adapt its CSS!

samuelmasse
samuelmasse previously approved these changes Dec 6, 2021
Copy link
Contributor

@samuelmasse samuelmasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working 👍

Comment on lines +32 to 34
// TODO: Visit and session reset are currently unsupported by @botpress/messaging-components
if (type === 'visit') {
return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we even display those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be relevant for the agent, knowing when was the last time a user visited the bot.

@laurentlp laurentlp merged commit dac5e3e into master Dec 10, 2021
@laurentlp laurentlp deleted the llp_hitl_use_messaging_components branch December 10, 2021 22:25
@EFF EFF mentioned this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: HITL Not Rendering Choice, Dropdown and Custom Components
2 participants