Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dx): fix failing tests #5739

Merged
merged 3 commits into from
Dec 3, 2021
Merged

fix(dx): fix failing tests #5739

merged 3 commits into from
Dec 3, 2021

Conversation

allardy
Copy link
Member

@allardy allardy commented Dec 2, 2021

Trying to fix the common flaky tests...

  1. Fails because randomly it generates 0
    image

  2. Fails because the delay is too thin and there's a race condition with bluebird and its timeout
    image

  3. The element can't be found because now nodes auto-open when pasted
    image

@allardy allardy marked this pull request as ready for review December 2, 2021 22:30
@allardy allardy requested a review from a team December 2, 2021 22:30
@allardy allardy merged commit 84a0bf5 into master Dec 3, 2021
@allardy allardy deleted the ya-fix-failing-tests branch December 7, 2021 05:28
@EFF EFF mentioned this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants