Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(channel-web): fix messaging tables schema in channel-web migration #5760

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

laurentlp
Copy link
Contributor

@laurentlp laurentlp commented Dec 13, 2021

Description

This PR fixes an issue where the table schema for msg_clients created by the channel-web migration of 12.26.0 differs from the one defined by the Messaging server.

This would cause users which tables were created during the migration to have a not null constraint on the providerId column that would result in issues when syncing with Messaging. The issue would only happen when you create or upload a bot with the same name as an old (deleted) bot.

Closes DEV-2190

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link
Contributor

@samuelmasse samuelmasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linear
Copy link

linear bot commented Dec 13, 2021

DEV-2190 Fix not null constraint on providerId in msg_clients

The table schema for msg_clients created by the channel-web migration of 12.26.0 differs from the one defined by the Messaging server.

This would cause users which tables were created during the migration to have a not null constraint on the providerId column that would result in issues when syncing with Messaging. The issue would only happen when you create or upload a bot with the same name as an old (deleted) bot.

@laurentlp laurentlp merged commit f52411e into master Dec 13, 2021
@laurentlp laurentlp deleted the llp_fix_channel_web_mig_messaging_tables_schema branch December 13, 2021 23:30
@EFF EFF mentioned this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants