Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Creating a hook named as its type does not work #1580

Closed
laurentlp opened this issue Dec 22, 2021 · 1 comment · Fixed by botpress/botpress#11698, botpress/botpress#11709 or botpress/botpress#11769
Closed

[BUG] Creating a hook named as its type does not work #1580

laurentlp opened this issue Dec 22, 2021 · 1 comment · Fixed by botpress/botpress#11698, botpress/botpress#11709 or botpress/botpress#11769
Labels
bug Something isn't working

Comments

@laurentlp
Copy link

Describe the bug
When adding a new hook, if you name it with the same name as the type of hook it is, it will result in a file named .js

To Reproduce

simplescreenrecorder-2021-12-21_16.17.52.mp4

Expected behavior
We should be able to name an after_incoming_middleware hook after_incoming_middleware.js without problem
@laurentlp laurentlp added the bug Something isn't working label Dec 22, 2021
@linear linear bot mentioned this issue Apr 5, 2022
Merged
This was referenced Apr 7, 2022
Closed
Merged
This was referenced Apr 20, 2022
Closed
Merged
@github-actions
Copy link

github-actions bot commented Apr 26, 2022 •
edited by laurentlp

Available on v12.27.0

@botpress botpress deleted a comment from github-actions bot Apr 26, 2022
@michaelmass michaelmass transferred this issue from botpress/botpress Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@laurentlp