fix(dialog): find flow now case insensitive #5771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Find Flow usage is inconsistent, providing a flow name was case insensitive, providing a flow file name was case sensitive providing a poor user experience. The changes provide a quality of live improvement for botpress sdk users.
Potential risks:
Currently Botpress Studio allows for creating a flow with same name with different casing, if any user uses that weird feature, this is breaking. We'll have to change flow creation logic in studio (which IMO would be the best)
Another non breaking solution would be to make this 100% case sensitive all the time, but that might be breaking for some users as well
Example
Say I have a flow named
HelpDesk
stored asHelpDesk.flow.json
Using the
jumpTo
functionBefore
jumpTo(/*args*/, 'helpdesk')
==> worksjumpTo(/*args*/, 'HelpDesk')
==> worksjumpTo(/*args*/, 'HelpDesk.flow.json')
==> worksjumpTo(/*args*/, 'helpdesk.flow.json')
==> not workingAfter
jumpTo(/*args*/, 'helpdesk')
==> worksjumpTo(/*args*/, 'HelpDesk')
==> worksjumpTo(/*args*/, 'HelpDesk.flow.json')
==> worksjumpTo(/*args*/, 'helpdesk.flow.json')
==> works