fix(migration): fix alter table migration not working with sqlite (#290)

* remove event ids * fix * bug * ej * fix
botpress · Dec 15, 2021 · 2599256 · 2599256
1 parent e6c8dd7
commit 2599256
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 15 deletions.
diff --git a/packages/engine/src/database/service.ts b/packages/engine/src/database/service.ts
@@ -90,6 +90,10 @@ export class DatabaseService extends Service {
     }
   }
 
+  getIsLite() {
+    return this.isLite
+  }
+
   getJson(val: any): any {
     if (this.isLite) {
       return val ? JSON.parse(val) : undefined

diff --git a/packages/engine/src/migration/migration.ts b/packages/engine/src/migration/migration.ts
@@ -3,12 +3,14 @@ import { Knex } from 'knex'
 export abstract class Migration {
   protected trx!: Knex.Transaction
   protected isDown!: boolean
+  protected isLite!: boolean
 
   abstract get meta(): MigrationMeta
 
-  async init(trx: Knex.Transaction, isDown: boolean) {
+  async init(trx: Knex.Transaction, isDown: boolean, isLite: boolean) {
     this.trx = trx
     this.isDown = isDown
+    this.isLite = isLite
   }
 
   async shouldRun() {

diff --git a/packages/engine/src/migration/service.ts b/packages/engine/src/migration/service.ts
@@ -99,6 +99,7 @@ export class MigrationService extends Service {
   private async runMigrations(migrations: Migration[]) {
     this.loggerDry.window([clc.bold(`Executing ${migrations.length} migration${migrations.length > 1 ? 's' : ''}`)])
 
+    await this.disableSqliteForeignKeys()
     const migrationsByVersion = _.groupBy(migrations, 'meta.version')
     const trx = await this.db.knex.transaction()
 
@@ -118,6 +119,8 @@ export class MigrationService extends Service {
       await trx.rollback()
       this.loggerDry.error(e, 'Migrations failed')
       throw new ShutDownSignal(1)
+    } finally {
+      await this.enableSqliteForeignKeys()
     }
   }
 
@@ -126,7 +129,7 @@ export class MigrationService extends Service {
 
     for (const migration of migrations) {
       this.loggerDry.info(`Running ${migration.meta.name}`)
-      await migration.init(trx, this.isDown)
+      await migration.init(trx, this.isDown, this.db.getIsLite())
 
       if (await migration.shouldRun()) {
         await migration.run()
@@ -192,4 +195,16 @@ export class MigrationService extends Service {
       }
     }
   }
+
+  private async disableSqliteForeignKeys() {
+    if (this.db.getIsLite()) {
+      await this.db.knex.raw('PRAGMA foreign_keys = OFF;')
+    }
+  }
+
+  private async enableSqliteForeignKeys() {
+    if (this.db.getIsLite()) {
+      await this.db.knex.raw('PRAGMA foreign_keys = ON;')
+    }
+  }
 }
diff --git a/packages/server/src/clients/events.ts b/packages/server/src/clients/events.ts
@@ -2,7 +2,7 @@ import { Emitter, uuid } from '@botpress/messaging-base'
 import { Client } from './types'
 
 export enum ClientEvents {
-  Updated = 4198497150859385
+  Updated
 }
 
 export interface ClientUpdatedEvent {

diff --git a/packages/server/src/conduits/events.ts b/packages/server/src/conduits/events.ts
@@ -1,10 +1,9 @@
 import { Emitter, uuid } from '@botpress/messaging-base'
 
-// Note: event type ids should be random numbers between -9007199254740991 and 9007199254740991
 export enum ConduitEvents {
-  Created = -8735528850944253,
-  Deleting = -2992045965298849,
-  Updated = -4333216986594445
+  Created,
+  Deleting,
+  Updated
 }
 
 export class ConduitEmitter extends Emitter<{

diff --git a/packages/server/src/instances/events.ts b/packages/server/src/instances/events.ts
@@ -1,12 +1,11 @@
 import { Emitter, uuid } from '@botpress/messaging-base'
 
-// Note: event type ids should be random numbers between -9007199254740991 and 9007199254740991
 export enum InstanceEvents {
-  Setup = -152025756428307,
-  SetupFailed = 1227260138789451,
-  Initialized = 8719796083603497,
-  InitializationFailed = -7790961391717513,
-  Destroyed = 1601810829650873
+  Setup,
+  SetupFailed,
+  Initialized,
+  InitializationFailed,
+  Destroyed
 }
 
 export class InstanceEmitter extends Emitter<{

diff --git a/packages/server/src/providers/events.ts b/packages/server/src/providers/events.ts
@@ -2,8 +2,8 @@ import { Emitter, uuid } from '@botpress/messaging-base'
 import { Provider } from './types'
 
 export enum ProviderEvents {
-  Updated = -6307907498173656,
-  Deleting = 4113861503631719
+  Updated,
+  Deleting
 }
 
 export interface ProviderUpdatedEvent {