fix(vonage): fix too many requests when using sandbox (#176)

* fix(vonage): fix too many requests when using sandbox * pr comment * limit to one req per sec when using vonage sandbox
botpress · Oct 12, 2021 · 59982f2 · 59982f2
1 parent 95ef289
commit 59982f2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/server/src/channels/vonage/senders/common.ts b/packages/server/src/channels/vonage/senders/common.ts
@@ -24,7 +24,8 @@ export class VonageCommonSender extends CommonSender {
                 }
 
                 context.logger.error(undefined, `${errBody.title}: ${errBody.detail} ${reasons}${errBody.type || ''}`)
-              } else if ((<any>err).statusCode === '429') {
+                // eslint-disable-next-line eqeqeq
+              } else if ((<any>err).statusCode == '429') {
                 context.logger.error(undefined, 'HTTPError (429): Too Many Requests')
               } else {
                 context.logger.error(undefined, 'UnknownError', err)

diff --git a/packages/server/src/instances/service.ts b/packages/server/src/instances/service.ts
@@ -183,9 +183,11 @@ export class InstanceService extends Service {
       return
     }
 
+    const promises = []
     for (const convmap of convmaps) {
-      void this.sendMessageToInstance(message, source, client!.providerId, convmap)
+      promises.push(this.sendMessageToInstance(message, source, client!.providerId, convmap))
     }
+    await Promise.all(promises)
   }
 
   private async sendMessageToInstance(