fix(migrations): fix migrations with targets that are out of bounds (#…

…274)

* rename file

* validate src and dst

* fix migrating to version above app version

packages/engine/src/migration/service.ts

@@ -45,6 +45,8 @@ export class MigrationService extends Service {
   }
 
   private async migrate() {
+    this.validateSrcAndDst()
+
     const migrations = this.listMigrationsToRun()
     if (!migrations.length && !this.isDry && !process.env.MIGRATE_CMD?.length) {
       return
@@ -66,6 +68,34 @@ export class MigrationService extends Service {
     await this.runMigrations(migrations)
   }
 
+  private validateSrcAndDst() {
+    if (this.isDown && semver.gt(this.dstVersion, this.srcVersion)) {
+      this.logger.error(
+        undefined,
+        `Invalid migration parameters: down migration cannot target a version (${this.dstVersion}) higher than the current server version (${this.srcVersion})`
+      )
+      throw new ShutDownSignal(1)
+    }
+
+    if (!this.isDown && semver.lt(this.dstVersion, this.srcVersion)) {
+      this.logger.error(
+        undefined,
+        `Invalid migration parameters: up migration cannot target a version (${this.dstVersion}) lower than the current server version (${this.srcVersion})`
+      )
+      throw new ShutDownSignal(1)
+    }
+
+    if (semver.gt(this.dstVersion, this.meta.app().version)) {
+      this.logger.error(
+        undefined,
+        `Invalid migration parameters: up migration cannot target a version (${
+          this.dstVersion
+        }) higher than the application version (${this.meta.app().version})`
+      )
+      throw new ShutDownSignal(1)
+    }
+  }
+
   private async runMigrations(migrations: Migration[]) {
     this.loggerDry.window([clc.bold(`Executing ${migrations.length} migration${migrations.length > 1 ? 's' : ''}`)])
 

packages/server/src/migrations/index.ts

@@ -1,4 +1,4 @@
 import { Migration } from '@botpress/messaging-engine'
-import { StatusMigration } from './0.1.18-status'
+import { StatusMigration } from './0.1.19-status'
 
 export const Migrations: { new (): Migration }[] = [StatusMigration]