Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitoring): always setup non lazy when spinned #158

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

samuelmasse
Copy link
Contributor

Fixes a problem when spinned from botpress that would stop retrying to setup channels after having failed for 5 times (and the config staying the same).

@laurentlp
Copy link
Contributor

Fixes a problem when spinned from botpress that would stop retrying to setup channels after having failed for 5 times (and the config staying the same).

So the solution and to keep retrying forever?

@samuelmasse
Copy link
Contributor Author

Yes that's not a problem with botpress. It's just a problem in the cloud to not waste ressources.

@samuelmasse
Copy link
Contributor Author

Otherwise you could fail to setup your channel correctly on botpress for whatever reason (maybe ngrok is not started), and then you would have no idea why it doesn't work. The only way to make it work would be to modify the config of your channel to some alternate value to force messaging to try setting it up again

@laurentlp laurentlp merged commit 2b22a68 into master Aug 25, 2021
@laurentlp laurentlp deleted the sm-always-retry-non-lazy-when-spinned branch August 25, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants