feat(converse): close collector when the bot has finished processing #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-1925 Improve converse on messaging to immediately empty the collectors when botpress has finished responding to an event
We use the done notification like converse did. We start by calling messaging to inform that a response is over every time and afterwards we include a flag in the messaging webhooks that indicates whether this message is being collected to avoid doing useless calls all the time. |
allardy
reviewed
Oct 27, 2021
laurentlp
reviewed
Oct 27, 2021
laurentlp
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
messages/turnroute that the runtime calls to indicate it has finished processing for an incoming message.Closes DEV-1925