fix(client): fix handling of not found errors #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
404 Not Founderrors were badly handled.Since we always access the
dataproperty from the response when making an API call, the function must always return an AxiosResponse which wasn't the case with 404s (it returnedundefinedinstead).Returning
{ data: undefined }could have been an option, but I opted to create an error handler specific to not found errors so we can reuse it. Also, it makes it clear where we handle those kinds of errors and I find it much more cleaner.Please, let me know if you have better ideas or any suggestions for improvements!
Also, this makes me think that we should take some time to standardize our response code and make sure that they are all the right ones in each context (e.g. send 404 everywhere a DB call can return empty data and switch from 403 to 401 where it should be the latter)