Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(channels): fixes for smooch and messenger #229

Merged
merged 3 commits into from
Nov 2, 2021
Merged

fix(channels): fixes for smooch and messenger #229

merged 3 commits into from
Nov 2, 2021

Conversation

franklevasseur
Copy link
Member

@franklevasseur franklevasseur commented Nov 1, 2021 •
edited
Loading

Head branch of team shake_your_botpress

Members of the team are:

Bug fixes:

  • fix(messenger): fix fetch pageId when in live mode (2pts)
  • fix(smooch): fix buttons (2pts)

DO NOT SQUASH THIS BRANCH

@franklevasseur franklevasseur marked this pull request as draft November 1, 2021 20:13
@franklevasseur franklevasseur mentioned this pull request Nov 1, 2021
Merged
@samuelmasse samuelmasse marked this pull request as ready for review November 2, 2021 14:23
laurentlp
laurentlp reviewed Nov 2, 2021
View reviewed changes
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions otherwise, looks good to me! Nice work

packages/server/src/channels/smooch/channel.ts Show resolved Hide resolved
packages/server/src/channels/smooch/conduit.ts Outdated Show resolved Hide resolved
@samuelmasse samuelmasse changed the title chore: head branch of team shake_your_botpress fix(channels): fixes for smooch and messenger Nov 2, 2021
@samuelmasse samuelmasse merged commit 42a1d5b into master Nov 2, 2021
@samuelmasse samuelmasse deleted the shake_your_botpress branch November 2, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlp laurentlp laurentlp left review comments

@samuelmasse samuelmasse samuelmasse approved these changes

@botpressops botpressops Awaiting requested review from botpressops

Assignees
No one assigned
Labels
X-Games
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franklevasseur @laurentlp @samuelmasse