-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(monitoring): fix listing outdated errored conduits #261
Conversation
DEV-1631 Listing outdated conduits should check if the conduit has passed the amount of allowed errors
Otherwise we keep listing the same conduits Move column "initialized" from msg_conduits to msg_status and move listOutdated to status service. listOutdated should not return conduits that have surpassed the maximum amount of failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to have a migration for this PR but otherwise, it looks fine to me. Nice work!
@laurentlp The migration is likely going to be just dropping the table. The status table doesn't store anything permanent so it's not really required to bother porting everything. |
You also edited the conduit table. I think it would be 1000 times better if we would do this the proper way. It can be done in another PR, but I strongly suggest we do both migrations. |
Note : remove version bump before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! 💯
Prevents conduits that have reached the maximum amount of errors from being fetched again when looking to initialize outdated conduits
Closes DEV-1631