Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitoring): fix listing outdated errored conduits #261

Merged
merged 22 commits into from
Nov 30, 2021

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Nov 26, 2021

Prevents conduits that have reached the maximum amount of errors from being fetched again when looking to initialize outdated conduits

Closes DEV-1631

@linear
Copy link

linear bot commented Nov 26, 2021

DEV-1631 Listing outdated conduits should check if the conduit has passed the amount of allowed errors

Otherwise we keep listing the same conduits

Move column "initialized" from msg_conduits to msg_status and move listOutdated to status service. listOutdated should not return conduits that have surpassed the maximum amount of failures

@samuelmasse samuelmasse changed the title fix(monitoring): fix listing oudated errored conduits fix(monitoring): fix listing outdated errored conduits Nov 26, 2021
@samuelmasse samuelmasse marked this pull request as ready for review November 27, 2021 00:33
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to have a migration for this PR but otherwise, it looks fine to me. Nice work!

packages/server/src/conduits/service.ts Outdated Show resolved Hide resolved
packages/server/src/status/service.ts Show resolved Hide resolved
@samuelmasse
Copy link
Contributor Author

@laurentlp The migration is likely going to be just dropping the table. The status table doesn't store anything permanent so it's not really required to bother porting everything.

@laurentlp
Copy link
Contributor

@laurentlp The migration is likely going to be just dropping the table. The status table doesn't store anything permanent so it's not really required to bother porting everything.

You also edited the conduit table. I think it would be 1000 times better if we would do this the proper way. It can be done in another PR, but I strongly suggest we do both migrations.

@samuelmasse
Copy link
Contributor Author

Note : remove version bump before merging

Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 💯

@samuelmasse samuelmasse merged commit c046dac into master Nov 30, 2021
@samuelmasse samuelmasse deleted the sm-fix-monitoring-errored-conduits branch November 30, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants