fix(migration): fix alter table migration not working with sqlite #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmasse
commented
Dec 14, 2021
Comment on lines
-3
to
7
| // Note: event type ids should be random numbers between -9007199254740991 and 9007199254740991 | ||
| export enum ConduitEvents { | ||
| Created = -8735528850944253, | ||
| Deleting = -2992045965298849, | ||
| Updated = -4333216986594445 | ||
| Created, | ||
| Deleting, | ||
| Updated | ||
| } |
There was a problem hiding this comment.
This is completely unrelated but these hardcoded ids don't have any use so I removed them
laurentlp
approved these changes
Dec 14, 2021
| @@ -90,6 +90,10 @@ export class DatabaseService extends Service { | |||
| } | |||
| } | |||
|
|
|||
| getIsLite() { | |||
There was a problem hiding this comment.
PP:
Suggested change
| getIsLite() { | |
| isLite() { |
laurentlp
reviewed
Dec 15, 2021
packages/server/src/build.ts
Outdated
| @@ -13,4 +13,4 @@ try { | |||
| }) | |||
| } catch (e) { | |||
| console.error("Couldn't get active branch", e) | |||
| } | |||
| } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We simply disable foreign keys when running sqlite migrations