Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(studio): preview content elements from skills #382

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

davidvitora
Copy link
Contributor

This feature allows the flow generator to return a list of content elements to be previewed in the flow editor.

Example:

image

The content element ids are saved in the node definition (same logic as transitions)

image

It can be specified in the flow generator function in the return object.

image

@davidvitora
Copy link
Contributor Author

davidvitora commented Aug 17, 2022

@laurentlp @EFF @slvnperron @allardy

There is also the possibility of having a "preview" property instead of "previewElements", where we could specify any kind of ActionItem to be previewed, including actions, which we can also preview today at normal nodes.

It would be something like

preview: [{
  type: sdk.NodeActionType.RenderElement,
  name: 'content-element-id-sdxsasf'
}, {
  type: sdk.NodeActionType.RunAction,
  name: 'basic-skills/choice_parse_answer'
}]

Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! @EFF can you please double-check!

Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions need to be addressed before we move forward ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants