return null when profile setting does not exist #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 97.11% 97.15% +0.04%
==========================================
Files 14 14
Lines 416 422 +6
Branches 28 36 +8
==========================================
+ Hits 404 410 +6
Misses 12 12
Continue to review full report at Codecov.
|
|
do we need tests for these? |
homerchen19
force-pushed
the
return-null
branch
from
495c442
to
d6a39b5
Compare
tw0517tw
reviewed
Oct 26, 2017
| @@ -1240,6 +1362,24 @@ describe('chat extension home URL', () => { | |||
| in_test: true, | |||
| }); | |||
| }); | |||
|
|
|||
| it('should response null when data is an emoty array', async () => { | |||
tw0517tw
approved these changes
Oct 26, 2017
homerchen19
force-pushed
the
return-null
branch
from
474817f
to
dd3b5cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #176